Fix strict mode docs #4150
Merged
Fix strict mode docs #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pditommaso
pushed a commit
that referenced
this pull request
Aug 23, 2023
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
|
Does this mean that it is impossible to override As a user, that is surprising to me. I would expect strict-mode to enforce better defaults and validate configuration more strictly, but I would not expect it to silently ignore certain settings. |
|
I agree it is strange 🤷♂️ Maybe it was not intentional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4148
When I documented strict mode, I said that certain options are true "by default", when in fact they are true regardless of any user setting.